Fix dialog layout

This commit is contained in:
Maarten Heremans 2024-08-06 21:30:11 +02:00
parent 64e96e6800
commit ce11540123
4 changed files with 101 additions and 9 deletions

View File

@ -100,7 +100,7 @@ func NewBaseDialogWithScreen(
parent, confirm) parent, confirm)
var err error var err error
d.ScreenHandler, err = NewScreenHandler( d.ScreenHandler, err = NewDialogScreenHandler(
filesystem, screenName, viewModel, localizer, assetLoader) filesystem, screenName, viewModel, localizer, assetLoader)
if err != nil { if err != nil {
LogWindowError(d, LoadScreen, err) LogWindowError(d, LoadScreen, err)
@ -148,7 +148,7 @@ func NewBaseDialogWithDataAndScreen(
parent, confirm, data) parent, confirm, data)
var err error var err error
d.ScreenHandler, err = NewScreenHandler( d.ScreenHandler, err = NewDialogScreenHandler(
filesystem, screenName, viewModel, localizer, assetLoader) filesystem, screenName, viewModel, localizer, assetLoader)
if err != nil { if err != nil {
LogWindowError(d, LoadScreen, err) LogWindowError(d, LoadScreen, err)
@ -228,7 +228,7 @@ func (d *BaseDialog) Initialize() fyne.CanvasObject {
LogWindowError(d, Initialize, err) LogWindowError(d, Initialize, err)
return nil return nil
} }
d.CanvasObj = obj d.CanvasObj = obj.(*screen.DialogScreen).AsContainer()
} }
return d.CanvasObj return d.CanvasObj
} }
@ -358,7 +358,7 @@ func (d *FormDialog) SetButtonLabels(
func (d *FormDialog) Initialize() fyne.CanvasObject { func (d *FormDialog) Initialize() fyne.CanvasObject {
if d.itemsFn == nil { if d.itemsFn == nil {
form := d.BaseDialog.Initialize().(*screen.Screen).AsContainer() form := d.BaseDialog.Initialize().(*fyne.Container)
d.itemsFn = func() []*widget.FormItem { d.itemsFn = func() []*widget.FormItem {
res := make([]*widget.FormItem, 0, len(form.Objects)/2) res := make([]*widget.FormItem, 0, len(form.Objects)/2)
for i := 0; i < len(form.Objects); i += 2 { for i := 0; i < len(form.Objects); i += 2 {

View File

@ -47,6 +47,11 @@ func (p *Padding) HasPadding() bool {
return p.Top > 0 || p.Bottom > 0 || p.Left > 0 || p.Right > 0 return p.Top > 0 || p.Bottom > 0 || p.Left > 0 || p.Right > 0
} }
type ToolTip struct {
Content string `yaml:"content"`
Localized bool `yaml:"localized"`
}
// Element represents the yaml description of a ui element // Element represents the yaml description of a ui element
type Element struct { type Element struct {
ID string `yaml:"id"` ID string `yaml:"id"`
@ -97,6 +102,7 @@ type Element struct {
Options map[string]any `yaml:"options"` Options map[string]any `yaml:"options"`
Disabled bool `yaml:"disabled"` Disabled bool `yaml:"disabled"`
Hidden bool `yaml:"hidden"` Hidden bool `yaml:"hidden"`
ToolTip *ToolTip `yaml:"tooltip"`
// Properties shared by most widgets // Properties shared by most widgets
Placeholder string `yaml:"placeholder"` Placeholder string `yaml:"placeholder"`

View File

@ -133,8 +133,12 @@ func (s *Screen) Resize(sz fyne.Size) {
} }
} }
func (s *Screen) MinSize() fyne.Size {
return s.CanvasObject.MinSize()
}
func (s *Screen) CreateRenderer() fyne.WidgetRenderer { func (s *Screen) CreateRenderer() fyne.WidgetRenderer {
return widget.NewSimpleRenderer(s.CanvasObject) return widget.NewSimpleRenderer(s.AsContainer())
} }
func (s *Screen) RegisterResizeCallback(cb func(fyne.Size)) { func (s *Screen) RegisterResizeCallback(cb func(fyne.Size)) {
@ -149,6 +153,42 @@ func (s *Screen) AsContainer() *fyne.Container {
return s.CanvasObject.(*fyne.Container) return s.CanvasObject.(*fyne.Container)
} }
type DialogScreen struct {
*Screen
}
func NewDialogScreen(
filesystem embed.FS,
name string,
screenHandler ScreenHandler,
) (src *DialogScreen, err error) {
screen, err := New(filesystem, name, screenHandler)
if err != nil {
return
}
src = &DialogScreen{screen}
return
}
func (s *DialogScreen) Initialize() (obj fyne.CanvasObject, err error) {
if s.CanvasObject, err = s.rootElement.BuildUI(s.screenHandler); err != nil {
err = fmt.Errorf("failed to build screen: %w", err)
return
}
obj = s
return
}
func (s *DialogScreen) Move(p fyne.Position) {
c := fyne.CurrentApp().Driver().CanvasForObject(s.CanvasObject)
movePos := fyne.Position{
X: p.X / c.Scale(),
Y: p.Y / c.Scale(),
}
s.CanvasObject.Move(movePos)
//fmt.Printf("%+v\n", s.CanvasObject.Position());
}
type TemplateScreenHandler struct { type TemplateScreenHandler struct {
localizer *i18n.Localizer localizer *i18n.Localizer
elementsMap map[string]*UIElement elementsMap map[string]*UIElement

View File

@ -2,6 +2,7 @@ package ui
import ( import (
"embed" "embed"
"errors"
"fmt" "fmt"
"io/fs" "io/fs"
"log" "log"
@ -14,6 +15,21 @@ import (
"github.com/nicksnyder/go-i18n/v2/i18n" "github.com/nicksnyder/go-i18n/v2/i18n"
) )
type screenType int
const (
stScreen screenType = iota
stDialog
)
type ScreenDefinition interface {
fyne.Widget
Initialize() (fyne.CanvasObject, error)
RegisterResizeCallback(func(fyne.Size))
RegisterMoveCallback(func(fyne.Position))
AsContainer() *fyne.Container
}
// ScreenHandler represents the handler for a screen. // ScreenHandler represents the handler for a screen.
// //
// It provides: // It provides:
@ -24,7 +40,7 @@ import (
// - List item templates and renderers // - List item templates and renderers
// - User interaction handlers // - User interaction handlers
type ScreenHandler struct { type ScreenHandler struct {
screenDefinition *screen.Screen screenDefinition ScreenDefinition
localizer *i18n.Localizer localizer *i18n.Localizer
viewModel BaseViewModel viewModel BaseViewModel
assetLoader func(string) (fs.File, error) assetLoader func(string) (fs.File, error)
@ -63,18 +79,48 @@ func NewScreenHandler(
viewModel BaseViewModel, viewModel BaseViewModel,
localizer *i18n.Localizer, localizer *i18n.Localizer,
assetLoader func(string) (fs.File, error), assetLoader func(string) (fs.File, error),
) (h *ScreenHandler, err error) {
return newScreenHandler(
stScreen, filesystem, screenName, viewModel, localizer, assetLoader)
}
func NewDialogScreenHandler(
filesystem embed.FS,
screenName string,
viewModel BaseViewModel,
localizer *i18n.Localizer,
assetLoader func(string) (fs.File, error),
) (h *ScreenHandler, err error) {
return newScreenHandler(
stDialog, filesystem, screenName, viewModel, localizer, assetLoader)
}
func newScreenHandler(
screenType screenType,
fileSystem embed.FS,
screenName string,
viewModel BaseViewModel,
localizer *i18n.Localizer,
assetLoader func(string) (fs.File, error),
) (h *ScreenHandler, err error) { ) (h *ScreenHandler, err error) {
h = new(ScreenHandler) h = new(ScreenHandler)
h.viewModel = viewModel h.viewModel = viewModel
h.localizer = localizer h.localizer = localizer
def, err := screen.New(filesystem, screenName, h) switch screenType {
case stScreen:
h.screenDefinition, err = screen.New(fileSystem, screenName, h)
case stDialog:
h.screenDefinition, err = screen.NewDialogScreen(fileSystem, screenName, h)
default:
err = errors.New("Unsupported screen type")
}
if err != nil { if err != nil {
err = fmt.Errorf("failure loading screen: %w", err) err = fmt.Errorf("failure loading screen: %w", err)
return return
} }
h.screenDefinition = def
h.assetLoader = assetLoader h.assetLoader = assetLoader
h.exportedElements = make(map[string]*screen.UIElement) h.exportedElements = make(map[string]*screen.UIElement)
@ -93,7 +139,7 @@ func NewScreenHandler(
} }
// ScreenDefinition returns the screen definition for the ScreenHandler. // ScreenDefinition returns the screen definition for the ScreenHandler.
func (h *ScreenHandler) ScreenDefinition() *screen.Screen { func (h *ScreenHandler) ScreenDefinition() ScreenDefinition {
return h.screenDefinition return h.screenDefinition
} }